Do not depend un unzip being available/having the expected interface
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I meant to open this PR upstream, but opened it here instead by mistake. Feel free to close or merge, your call ;.) Pr submitted upstream at raccoongang#23 |
* Add derex project for local development and for CI testing * Move package files in a subdirectory. This is needed to be able to symlink package contents in the derex project requirements directory. * Add package MANIFEST file and include_package_data argument to setup.py instead of manually parsing package data * Use direnv for local development * Add github workflow CI test * Update README
* Cleanup code * Use student_view for Studio instead of defining an empty author_view * Load uncompressed SCORM packages files on the default_storage
… instead of the now deprecated SettingsType.AWS
Feature/upload to contentstore
|
I forgot about this PR and continued working on the master branch on our side. Now the PR is no longer in scope. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code expects the
unzipbinary to be available, and to behave in a certain way.This is not always the case: for instance on Alpine Linux the default
unzipis provided by BusyBox, and is a stripped-down version.This pull requests performs the unzipping of the file only relying on the python standard library.